-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - simplify continuation management to help future migration #8324
Draft
mcculls
wants to merge
1
commit into
master
Choose a base branch
from
mcculls/simplify-continuations
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 12 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~5a01802146, baseline=1.47.0-SNAPSHOT~9af5347cda
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1046543
Total [baseline] (10.398 s) : 0, 10397847
Agent [candidate] (1.052 s) : 0, 1051758
Total [candidate] (10.513 s) : 0, 10512963
section appsec
Agent [baseline] (1.183 s) : 0, 1183411
Total [baseline] (10.724 s) : 0, 10724394
Agent [candidate] (1.187 s) : 0, 1187293
Total [candidate] (10.767 s) : 0, 10766617
section iast
Agent [baseline] (1.17 s) : 0, 1169606
Total [baseline] (10.997 s) : 0, 10997037
Agent [candidate] (1.177 s) : 0, 1177200
Total [candidate] (10.939 s) : 0, 10939261
section profiling
Agent [baseline] (1.261 s) : 0, 1260753
Total [baseline] (10.808 s) : 0, 10807551
Agent [candidate] (1.285 s) : 0, 1285016
Total [candidate] (10.908 s) : 0, 10907693
gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~5a01802146, baseline=1.47.0-SNAPSHOT~9af5347cda
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.574 ms) : 0, 718574
BytebuddyAgent [candidate] (722.724 ms) : 0, 722724
GlobalTracer [baseline] (243.689 ms) : 0, 243689
GlobalTracer [candidate] (244.619 ms) : 0, 244619
AppSec [baseline] (55.511 ms) : 0, 55511
AppSec [candidate] (55.885 ms) : 0, 55885
Remote Config [baseline] (715.553 µs) : 0, 716
Remote Config [candidate] (729.226 µs) : 0, 729
Telemetry [baseline] (12.792 ms) : 0, 12792
Telemetry [candidate] (12.454 ms) : 0, 12454
section appsec
BytebuddyAgent [baseline] (732.057 ms) : 0, 732057
BytebuddyAgent [candidate] (734.634 ms) : 0, 734634
GlobalTracer [baseline] (240.009 ms) : 0, 240009
GlobalTracer [candidate] (240.757 ms) : 0, 240757
AppSec [baseline] (176.395 ms) : 0, 176395
AppSec [candidate] (176.78 ms) : 0, 176780
Remote Config [baseline] (698.475 µs) : 0, 698
Remote Config [candidate] (658.415 µs) : 0, 658
Telemetry [baseline] (8.245 ms) : 0, 8245
Telemetry [candidate] (8.308 ms) : 0, 8308
IAST [baseline] (21.628 ms) : 0, 21628
IAST [candidate] (21.847 ms) : 0, 21847
section iast
BytebuddyAgent [baseline] (832.05 ms) : 0, 832050
BytebuddyAgent [candidate] (838.915 ms) : 0, 838915
GlobalTracer [baseline] (233.469 ms) : 0, 233469
GlobalTracer [candidate] (234.04 ms) : 0, 234040
AppSec [baseline] (55.432 ms) : 0, 55432
AppSec [candidate] (53.074 ms) : 0, 53074
Remote Config [baseline] (614.946 µs) : 0, 615
Remote Config [candidate] (612.075 µs) : 0, 612
Telemetry [baseline] (8.707 ms) : 0, 8707
Telemetry [candidate] (8.805 ms) : 0, 8805
IAST [baseline] (24.086 ms) : 0, 24086
IAST [candidate] (26.435 ms) : 0, 26435
section profiling
ProfilingAgent [baseline] (95.452 ms) : 0, 95452
ProfilingAgent [candidate] (97.215 ms) : 0, 97215
BytebuddyAgent [baseline] (705.089 ms) : 0, 705089
BytebuddyAgent [candidate] (720.626 ms) : 0, 720626
GlobalTracer [baseline] (352.963 ms) : 0, 352963
GlobalTracer [candidate] (359.376 ms) : 0, 359376
AppSec [baseline] (55.215 ms) : 0, 55215
AppSec [candidate] (54.776 ms) : 0, 54776
Remote Config [baseline] (708.157 µs) : 0, 708
Remote Config [candidate] (778.139 µs) : 0, 778
Telemetry [baseline] (8.95 ms) : 0, 8950
Telemetry [candidate] (9.018 ms) : 0, 9018
Profiling [baseline] (95.477 ms) : 0, 95477
Profiling [candidate] (97.239 ms) : 0, 97239
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~5a01802146, baseline=1.47.0-SNAPSHOT~9af5347cda
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.04 s) : 0, 1040383
Total [baseline] (8.639 s) : 0, 8639356
Agent [candidate] (1.037 s) : 0, 1036812
Total [candidate] (8.623 s) : 0, 8622895
section iast
Agent [baseline] (1.172 s) : 0, 1171877
Total [baseline] (9.225 s) : 0, 9224635
Agent [candidate] (1.173 s) : 0, 1172865
Total [candidate] (9.23 s) : 0, 9230243
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.177 s) : 0, 1177303
Total [baseline] (9.221 s) : 0, 9220519
Agent [candidate] (1.17 s) : 0, 1169551
Total [candidate] (9.201 s) : 0, 9200509
section iast_TELEMETRY_OFF
Agent [baseline] (1.168 s) : 0, 1168149
Total [baseline] (9.212 s) : 0, 9212470
Agent [candidate] (1.184 s) : 0, 1183909
Total [candidate] (9.204 s) : 0, 9203631
gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~5a01802146, baseline=1.47.0-SNAPSHOT~9af5347cda
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (713.946 ms) : 0, 713946
BytebuddyAgent [candidate] (712.734 ms) : 0, 712734
GlobalTracer [baseline] (242.141 ms) : 0, 242141
GlobalTracer [candidate] (241.799 ms) : 0, 241799
AppSec [baseline] (56.135 ms) : 0, 56135
AppSec [candidate] (55.079 ms) : 0, 55079
Remote Config [baseline] (728.719 µs) : 0, 729
Remote Config [candidate] (710.288 µs) : 0, 710
Telemetry [baseline] (12.236 ms) : 0, 12236
Telemetry [candidate] (11.357 ms) : 0, 11357
section iast
BytebuddyAgent [baseline] (833.862 ms) : 0, 833862
BytebuddyAgent [candidate] (834.569 ms) : 0, 834569
GlobalTracer [baseline] (233.762 ms) : 0, 233762
GlobalTracer [candidate] (234.414 ms) : 0, 234414
AppSec [baseline] (55.584 ms) : 0, 55584
AppSec [candidate] (53.7 ms) : 0, 53700
Remote Config [baseline] (625.961 µs) : 0, 626
Remote Config [candidate] (616.877 µs) : 0, 617
Telemetry [baseline] (8.719 ms) : 0, 8719
Telemetry [candidate] (8.645 ms) : 0, 8645
IAST [baseline] (24.095 ms) : 0, 24095
IAST [candidate] (25.659 ms) : 0, 25659
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (837.536 ms) : 0, 837536
BytebuddyAgent [candidate] (831.982 ms) : 0, 831982
GlobalTracer [baseline] (235.167 ms) : 0, 235167
GlobalTracer [candidate] (233.406 ms) : 0, 233406
AppSec [baseline] (54.151 ms) : 0, 54151
AppSec [candidate] (52.284 ms) : 0, 52284
Remote Config [baseline] (618.992 µs) : 0, 619
Remote Config [candidate] (608.554 µs) : 0, 609
Telemetry [baseline] (8.791 ms) : 0, 8791
Telemetry [candidate] (8.767 ms) : 0, 8767
IAST [baseline] (25.756 ms) : 0, 25756
IAST [candidate] (27.273 ms) : 0, 27273
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (830.862 ms) : 0, 830862
BytebuddyAgent [candidate] (843.255 ms) : 0, 843255
GlobalTracer [baseline] (233.464 ms) : 0, 233464
GlobalTracer [candidate] (236.7 ms) : 0, 236700
AppSec [baseline] (54.786 ms) : 0, 54786
AppSec [candidate] (53.966 ms) : 0, 53966
Remote Config [baseline] (617.759 µs) : 0, 618
Remote Config [candidate] (618.55 µs) : 0, 619
Telemetry [baseline] (8.632 ms) : 0, 8632
Telemetry [candidate] (8.589 ms) : 0, 8589
IAST [baseline] (24.489 ms) : 0, 24489
IAST [candidate] (25.295 ms) : 0, 25295
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~5a01802146, baseline=1.47.0-SNAPSHOT~9af5347cda
dateFormat X
axisFormat %s
section baseline
no_agent (1.352 ms) : 1332, 1371
. : milestone, 1352,
appsec (1.74 ms) : 1716, 1763
. : milestone, 1740,
appsec_no_iast (1.756 ms) : 1732, 1779
. : milestone, 1756,
iast (1.504 ms) : 1480, 1528
. : milestone, 1504,
profiling (1.501 ms) : 1477, 1525
. : milestone, 1501,
tracing (1.482 ms) : 1457, 1507
. : milestone, 1482,
section candidate
no_agent (1.353 ms) : 1333, 1373
. : milestone, 1353,
appsec (1.749 ms) : 1725, 1773
. : milestone, 1749,
appsec_no_iast (1.732 ms) : 1708, 1756
. : milestone, 1732,
iast (1.492 ms) : 1467, 1516
. : milestone, 1492,
profiling (1.488 ms) : 1465, 1512
. : milestone, 1488,
tracing (1.496 ms) : 1472, 1520
. : milestone, 1496,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~5a01802146, baseline=1.47.0-SNAPSHOT~9af5347cda
dateFormat X
axisFormat %s
section baseline
no_agent (380.978 µs) : 359, 403
. : milestone, 381,
iast (502.39 µs) : 480, 525
. : milestone, 502,
iast_FULL (738.549 µs) : 717, 761
. : milestone, 739,
iast_GLOBAL (552.561 µs) : 530, 575
. : milestone, 553,
iast_HARDCODED_SECRET_DISABLED (506.258 µs) : 485, 528
. : milestone, 506,
iast_INACTIVE (459.217 µs) : 438, 480
. : milestone, 459,
iast_TELEMETRY_OFF (496.602 µs) : 473, 520
. : milestone, 497,
tracing (445.259 µs) : 424, 466
. : milestone, 445,
section candidate
no_agent (379.928 µs) : 358, 402
. : milestone, 380,
iast (500.061 µs) : 478, 522
. : milestone, 500,
iast_FULL (736.303 µs) : 714, 759
. : milestone, 736,
iast_GLOBAL (552.422 µs) : 530, 575
. : milestone, 552,
iast_HARDCODED_SECRET_DISABLED (499.896 µs) : 478, 521
. : milestone, 500,
iast_INACTIVE (455.354 µs) : 434, 477
. : milestone, 455,
iast_TELEMETRY_OFF (498.649 µs) : 475, 522
. : milestone, 499,
tracing (454.323 µs) : 433, 475
. : milestone, 454,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~5a01802146, baseline=1.47.0-SNAPSHOT~9af5347cda
dateFormat X
axisFormat %s
section baseline
no_agent (15.399 s) : 15399000, 15399000
. : milestone, 15399000,
appsec (15.188 s) : 15188000, 15188000
. : milestone, 15188000,
iast (18.546 s) : 18546000, 18546000
. : milestone, 18546000,
iast_GLOBAL (18.046 s) : 18046000, 18046000
. : milestone, 18046000,
profiling (15.57 s) : 15570000, 15570000
. : milestone, 15570000,
tracing (14.956 s) : 14956000, 14956000
. : milestone, 14956000,
section candidate
no_agent (15.24 s) : 15240000, 15240000
. : milestone, 15240000,
appsec (15.224 s) : 15224000, 15224000
. : milestone, 15224000,
iast (18.868 s) : 18868000, 18868000
. : milestone, 18868000,
iast_GLOBAL (17.897 s) : 17897000, 17897000
. : milestone, 17897000,
profiling (14.968 s) : 14968000, 14968000
. : milestone, 14968000,
tracing (15.023 s) : 15023000, 15023000
. : milestone, 15023000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~5a01802146, baseline=1.47.0-SNAPSHOT~9af5347cda
dateFormat X
axisFormat %s
section baseline
no_agent (1.463 ms) : 1452, 1475
. : milestone, 1463,
appsec (2.347 ms) : 2304, 2390
. : milestone, 2347,
iast (2.098 ms) : 2043, 2152
. : milestone, 2098,
iast_GLOBAL (2.147 ms) : 2092, 2203
. : milestone, 2147,
profiling (1.954 ms) : 1911, 1997
. : milestone, 1954,
tracing (1.947 ms) : 1905, 1990
. : milestone, 1947,
section candidate
no_agent (1.47 ms) : 1459, 1482
. : milestone, 1470,
appsec (2.36 ms) : 2317, 2403
. : milestone, 2360,
iast (2.099 ms) : 2045, 2154
. : milestone, 2099,
iast_GLOBAL (2.142 ms) : 2087, 2197
. : milestone, 2142,
profiling (1.974 ms) : 1929, 2019
. : milestone, 1974,
tracing (1.929 ms) : 1887, 1971
. : milestone, 1929,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]